-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open in Kaggle badge #1773
Add Open in Kaggle badge #1773
Conversation
add Open in Kaggle badge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @pizzaz93, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master update by running the following, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov3.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
@pizzaz93 thanks for the PR! I tried to click the Kaggle badge in your branch but it doesn't seem to work correctly: |
@pizzaz93 the link itself seems to work well, it just appears to be a problem with the notebook integration of the badge maybe: |
@pizzaz93 we also have a seperate kaggle notebook here, though we have to keep it updated every time we have a new release here, so your link would appear to be a better solution with less maintenance: |
In regards to it not working, is it not opening in a new window or something else? I'm glad to hear that the badge makes things more streamlined. |
I get these two windows before and after clicking the badge, on Chrome MacOS latest versions. |
The badge works when you ctrl(cmd)+click to open it in a new window. I know the colab badge works without having to do that. |
Open badge in same window
I added a new commit to make the badge work without having to use |
@pizzaz93 thanks the click works now! Is there a reason for the |
@pizzaz93 that's interesting, I tried to center and space, but no luck. Instead the badges are paired one above the other: This is similar to the preexisting problematic badge behavior at the bottom of the notebook also. They seem to render differently in the notebook environment than in the GitHub markdown unfortunately. |
For space between the badges I've found "br" tags to be a solution or "&nb sp;". |
@pizzaz93 PR is merged. Thank you for your contributions! YOLOv5 could also use a similar update if you'd like to submit a PR there! |
Add Kaggle Badge that allows for opening the .ipynb as a Kaggle Notebook as seen here https://www.kaggle.com/product-feedback/152480.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updates to YOLOv3 tutorial notebook adding Kaggle as an environment option.
📊 Key Changes
🎯 Purpose & Impact